Repository navigation
feat: test archive integrity without extracting - #143
Merged
Merged
Conversation
nextestudios
force-pushed
the
feature/66-archive-test
branch
from
September 27, 2026 04:57
fd0fc1e to
e63ab5d
Compare
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
nextestudios
force-pushed
the
feature/66-archive-test
branch
from
September 27, 2026 05:02
e63ab5d to
0ec6c36
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IArchiveService.TestAsync/SafeExtractor.TestAsync: reads every file entry through the same path as extraction and discards the data (Stream.Null). The read/verify loop (limits on bytes actually read, declared size, CRC, AE-2 CRC-0 skip) was factored intoCopyVerified, shared by extraction and test, so both enforce the same checks. Nothing is written: no dedicated folder, no staging.ItemResultper entry: succeeded (CRC matched), succeeded withNoChecksum(TAR/GZ/AES AE-2: read fully, nothing to compare), failed (with the reason), not processed (after cancel or a fatal stream error).OperationKind.TestArchive) with progress and cancel; password-protected archives use the existing password keyboard (wrong password asks again). The result dialog lists counts, names failing entries and states it is not a virus scan.docs/archive-support.mdand both changelogs updated. README no longer lists ZIP AES/ZIP64 as unvalidated (done in test: validate ZIP64 extraction with generated fixtures #131 and feat: validate WinZip AES ZIP extraction #137).Tested in CI
ArchiveTestTests: corrupted ZIP names the failing entry and the temp dir is unchanged; good ZIP reports OK; TAR entries flagged as no checksum; cancelling from a progress report stops and marks the rest not processed.Manual checks
Closes #66
🤖 Generated with Claude Code