Repository navigation
fix: two-button pads reach Actions and Menu - #128
Merged
Merged
Conversation
A profile mapped with only directions, confirm and back could not open Actions or Menu. For profiles lacking North and/or Start, holding Confirm for 0.6 s now opens Actions and holding Back opens the Menu; short presses are unchanged (they fire on release). The bottom bar shows these on the Confirm/Back glyphs with "(segure)" for such devices. Refs #79 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Sep 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The spec says a two-button pad must reach every essential function, but a joystick profile mapped with only directions + confirm + back (all optional steps skipped in the #79 wizard) could not open Actions or Menu.
LongPressFallback/LongPressTranslator(Core): for profiles lacking North and/or Start only, the profile's Confirm/Back controls are delayed to release. A short press emits the same button as before; held for 0.6 s they emit one North (→ Actions) / Start (→ Menu) press, and the release emits nothing. Follows the confirm/back convention. Gamepads and profiles that map North/Start are unchanged.InputHostruns profiled controls through it (ticked in the input loop, rebuilt on profile or convention changes) and publishes the active device's fallback toAppController.SetLongPressFallback.A Ações (segure)).⌫ ◀ ▶in the on-screen keyboard no longer repeats. The controller test screen (feat: in-app controller test screen #127) shows the plain profile controls without the fallback.input-and-focus.md, GUIDE pair,TESTING.mdmanual check, both changelogs.Tests
ControllerMappingWizardTestsfeeds raw events through the realControllerProfileTranslator→LongPressTranslator→InputRouter: short Confirm/Back/direction unchanged; held 0.6 s →OpenContextMenuandOpenAppMenuonce, no Confirm/Back on release; a profile with North/Start gets no fallback.docs/TESTING.md): timing feel, prompts on screen.Refs #79
🤖 Generated with Claude Code