Skip to content

feat: delete to the Windows Recycle Bin with explicit permanent delete - #104

Merged
nextestudios merged 1 commit into
mainfrom
feature/12-recycle-bin
Sep 27, 2026
Merged

nextestudios merged 1 commit into
mainfrom
feature/12-recycle-bin

Conversation

@nextestudios

Copy link
Copy Markdown
Owner

Closes #12.

  • Delete… on files, folders and marked items.
  • Recyclable locations: Move to Recycle Bin (default action) and a separate Delete permanently… with its own confirmation.
  • Locations without a Recycle Bin (e.g. network/removable): the dialog states the delete is permanent; confirmations start on Cancel.
  • Recycle uses SHFileOperationW with FOF_WANTNUKEWARNING, so it never silently becomes a permanent delete.
  • Permanent delete never follows junctions (Windows integration test); focus moves to the next item.

🤖 Generated with Claude Code

- Delete… on files, folders and marked items. Recyclable locations offer
  Move to Recycle Bin, plus a separate Delete permanently… confirmation.
- Locations without a Recycle Bin say the delete is permanent and require a
  specific confirmation; both start on Cancel. The Shell call uses
  FOF_WANTNUKEWARNING so a recycle never silently becomes a permanent delete.
- Permanent delete removes links/junctions without following them; focus moves
  to the next item afterwards.

Closes #12

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@nextestudios
nextestudios merged commit 67b46f9 into main Sep 27, 2026
1 check passed
@nextestudios
nextestudios deleted the feature/12-recycle-bin branch September 27, 2026 01:46
This was referenced Sep 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: delete to the Windows Recycle Bin with explicit permanent-delete fallback

1 participant