Render highlighted documents - #9045
Closed
hweihwang wants to merge 3 commits into
Closed
Conversation
Parse immutable documents, normalize their semantic structure, and emit bounded stable change descriptors. Support one shared schema for both parsed documents. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Expose the Text comparison factory and render grouped changes by document section. Preserve every changed-only preview in multi-edit blocks with semantic deletion and insertion markup. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
Mount both immutable documents once, apply semantic decorations, support independent pane navigation, and provide an accessible single-pane layout for narrow containers. Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Hoang Pham <hoangmaths96@gmail.com>
This was referenced Aug 14, 2026
Open
hweihwang
requested review from
max-nextcloud and
mejo-
and removed request for
max-nextcloud
August 14, 2026 16:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In one sentence: the Full documents view — both originals read-only, highlighted, and navigable.
What and why
The Changes view says what changed — but it doesn't let you read the document, so you can't tell whether an edited sentence still fits its paragraph. This PR adds the view that shows you.
What's in this PR
Wide mode. Non-colour cues throughout, so the highlights never carry the meaning alone.
Paired mode. Container width — not viewport width — selects the mode.
Narrow mode. One document is never shown unlabelled as if it were a comparison.
Design notes
scrollIntoViewis not usable here: it walks every scrollable ancestor and would drag the dialog around. A pane-scoped helper preserves scroll position and reports failure instead of doing nothing.Stack
Depends on: #9044. Followed by #9046. Opened stacked — the diff narrows as predecessors merge; I'll rebase before review.
Verification
ts:checkandlintpass; complete suite 1,862/1,862. Empty-side and paired-gap regressions are pinned by tests; highlight positions are asserted against the originals in the live end-to-end suite.AI assistance
Commits carry
Assisted-by: Codex:gpt-5.6-sol; an independent review pass was run with Claude Opus 5. Description drafted with Hermes (deepseek-v4-pro) from my notes, then reviewed by me.Related