fix(LinkBubble): Display link bubble view only if href is set - #5538
Merged
Conversation
mejo-
enabled auto-merge
March 20, 2024 16:08
This prevents requests to `/resolve?reference=.../null` when a document gets opened without a link being selected. Contributes to nextcloud/collectives#1167 Signed-off-by: Jonas <jonas@freesources.org>
mejo-
force-pushed
the
fix/linkbubble_no_href
branch
from
March 20, 2024 16:32
536b528 to
9e74ac9
Compare
mejo-
disabled auto-merge
March 20, 2024 17:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents requests to
/resolve?reference=.../nullwhen a document gets opened without a link being selected.Contributes to nextcloud/collectives#1167
馃弫 Checklist
npm run lint/npm run stylelint/composer run cs:check)