fix: Fix permission issue when uploading a chunked file - #59654
Merged
Conversation
CarlSchwan
requested review from
Altahrim,
icewind1991,
leftybournes and
nfebe
and removed request for
a team
April 15, 2026 15:22
CarlSchwan
force-pushed
the
carl/permission-upload
branch
3 times, most recently
from
April 15, 2026 15:42
53e9c32 to
f2ce921
Compare
susnux
approved these changes
Apr 15, 2026
CarlSchwan
force-pushed
the
carl/permission-upload
branch
from
April 15, 2026 15:48
f2ce921 to
d10cf97
Compare
provokateurin
approved these changes
Apr 15, 2026
Member
Author
|
/backport to stable33 |
Member
Author
|
/backport to stable32 |
8 tasks
icewind1991
reviewed
Apr 15, 2026
Member
Author
|
Integrations test failures look related 😢 |
Contributor
Yeah, uploading a file that isn't being chunked fails as the renaming doesn't work.
|
DerDreschner
requested changes
Apr 24, 2026
CarlSchwan
force-pushed
the
carl/permission-upload
branch
from
May 5, 2026 14:52
b4b4deb to
4cc6e96
Compare
provokateurin
approved these changes
May 6, 2026
DerDreschner
force-pushed
the
carl/permission-upload
branch
from
May 7, 2026 09:53
4cc6e96 to
d6a0078
Compare
DerDreschner
enabled auto-merge
May 7, 2026 09:53
DerDreschner
approved these changes
May 7, 2026
DerDreschner
force-pushed
the
carl/permission-upload
branch
from
May 7, 2026 12:45
d6a0078 to
d0309d0
Compare
Follow up from #59511 Signed-off-by: Carl Schwan <carlschwan@kde.org>
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
Co-authored-by: David Dreschner <david.dreschner@nextcloud.com> Signed-off-by: Carl Schwan <carl@carlschwan.eu> Signed-off-by: Carl Schwan <carlschwan@kde.org>
DerDreschner
force-pushed
the
carl/permission-upload
branch
from
May 8, 2026 09:47
d0309d0 to
23447f1
Compare
Contributor
|
I've run the failed cypress tests on my local machine using this branch and they succeeded ( |
ChristophWurst
disabled auto-merge
May 8, 2026 12:20
ChristophWurst
added
the
4. to release
This was referenced May 8, 2026
Merged
Merged
This was referenced Jun 5, 2026
patrickdmrezende
added a commit
to avuz-conecta/avuz-server
that referenced
this pull request
Aug 27, 2026
Point upgrade 33.0.0 -> 33.0.8. Brings the native fix for chunked upload via public file-drop links on S3 primary storage (NotPermittedException on the assembly MOVE): DirPermissionsMask masks only the users files/ home, leaving uploads/ unmasked, and its rename() allows the assembly when source is deletable. Upstream nextcloud/server nextcloud#59511 + nextcloud#59654, backported to stable33 as nextcloud#59552 + nextcloud#60240 (shipped 33.0.4). Removes the need for an Avuz overlay for this bug. Conflict resolution: - 3rdparty: pinned to v33.0.8 gitlink (Composer autoloader must match NC). - dist/files-main.js(.map): took v33.0.8; the image rebuilds dist from source at build (Dockerfile npm ci + npm run build), so committed dist is a throwaway artifact. Verified surviving: 3 core source patches (files hide-webdav, upload-leave warning), spreed chunked-recording overlay sentinel, avuz_theme EMailTemplate subclass (parent unchanged in 33.0.8), themes/avuz. No source-level conflicts with any Avuz customization (upgrade-scan: 0 conflicts).
patrickdmrezende
added a commit
to avuz-conecta/avuz-server
that referenced
this pull request
Aug 27, 2026
Nextcloud 33.0.0 -> 33.0.8 point upgrade. Brings the native fix for chunked upload via public file-drop links on S3 (DirPermissionsMask; upstream nextcloud#59511+nextcloud#59654, backported to stable33 in 33.0.4). Validated before merge: - upgrade-scan: 0 conflicts; 44/44 customizations survive. - In-place migration rehearsed on a snapshot of prod eco-ambiental's real DB (341k filecache rows) via the entrypoint's disable->upgrade->reenable-force sequence: clean, needsDbUpgrade=false, 50 apps enabled. - Fix proven end-to-end: >120MB file-drop assembles on Ceph S3. deck submodule kept at 1.18.10 (1832a86); the upgrade branch never touched it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up from #59511
Summary
TODO
Checklist
3. to review, feature component)stable32)AI (if applicable)