Error with external password link

[thekoma]

Expected behaviour

Open external portal for password change (LDAP)

Actual behaviour

JS Takeover the click instead opening a new window

Server configuration

Operating system:
Centos7

Web server:
Nginx
Database:
Mariadb 10.2
PHP version:
7.0
Nextcloud version: (see Nextcloud admin page)
13.0.1
Updated from an older Nextcloud/ownCloud or fresh install:
from 13.0.0

The override for an external site to reset the password won't work anymore:

 'lost_password_link' => 'https://reset.mysite.url',

The code generated is

				<a id="lost-password" href="https://reset.irideos.it">
					Forgot password?				</a>
				<a id="lost-password-back" href="" style="display:none;">
					Back to log in				</a>

but the javascript override the click (href) asking for an username/email to reset the password.
Proceeding inserting those data causes the interface to reply a 'Password reset is disabled'

[thekoma]

https://youtu.be/P3V1wex7dtk

[kgw4it]

The issue is caused here: https://github.com/nextcloud/server/blob/master/core/js/lostpassword.js#L49

If the user didn't enter something in the username/email field, the form is submitted (https://github.com/nextcloud/server/blob/master/core/js/lostpassword.js#L67) on click on the forgot-password link. Only if the user entered something before clicking the link, the redirect to the proper page is done in javascript.

I think the if-construct here https://github.com/nextcloud/server/blob/master/core/js/lostpassword.js#L69 should be put before the check whether or not a username/email was entered.

[MorrisJobke]

https://youtu.be/P3V1wex7dtk

@skjnldsv @juliushaertl @jancborchardt Didn't one of you revamped the lost password dialog to be not a page reload but rather a transition?

This seems not to work anymore with external password reset pages.

[piranhaphish]

Why was this issue closed? #10325 is a completely separate issue dealing with the absence of a password reset url, effectively disabling it.

This issue here is about properly utilizing the password reset link when the login form is empty.

[thekoma]

Requesting reopen

[skjnldsv]

I'm not sure i understand the issue here.
Wasn't it just that the link to external pass reset was not working?