Skip to content

Avoid unconditional loginName2UserName in UserManager::getUserObject #7445

Description

@blizzz

Apparently it was once introduced to fix a bug when resetting the password (typical for local users). However, this is attempted in every call for the user object, and in case of LDAP leading to an additional lookup using the internally used name to the LDAP server.

Proposed solution:

  1. write a test to resest password with different case loginname
    2a. throw the preLoginNameUsedAsUserName Hook in the Controller. Ideally move also to dispatcher
    2b. Since it is use just an optional user backend method, just establish an API method in the manager and call it when necessary, to avoid hooks. Other usages (I am aware about federate sharing) should be revisited, too.

Perhaps better for 14.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions