Special characters in file name cause fatal exception in webdav

[GiantCrocodile]

When you try to rename a file with special characters inside (like <) you get an exception in protocol:

{
   "reqId":"<removed>",
   "level":4,
   "time":"<removed>",
   "remoteAddr":"<removed>",
   "user":"<removed>",
   "app":"webdav",
   "method":"MOVE",
   "url":"\/remote.php\/webdav\/Photos\/Coast.jpg",
   "message":"Exception: {\"Exception\":\"Sabre\\\\DAV\\\\Exception\\\\Conflict\",\"Message\":\"The destination node is not found\",\"Code\":0,\"Trace\":\"#0 \\\/var\\\/www\\\/nextcloud\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/CorePlugin.php(624): Sabre\\\\DAV\\\\Server->getCopyAndMoveInfo(Object(Sabre\\\\HTTP\\\\Request))\\n#1 [internal function]: Sabre\\\\DAV\\\\CorePlugin->httpMove(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#2 \\\/var\\\/www\\\/nextcloud\\\/3rdparty\\\/sabre\\\/event\\\/lib\\\/EventEmitterTrait.php(105): call_user_func_array(Array, Array)\\n#3 \\\/var\\\/www\\\/nextcloud\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(479): Sabre\\\\Event\\\\EventEmitter->emit('method:MOVE', Array)\\n#4 \\\/var\\\/www\\\/nextcloud\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php(254): Sabre\\\\DAV\\\\Server->invokeMethod(Object(Sabre\\\\HTTP\\\\Request), Object(Sabre\\\\HTTP\\\\Response))\\n#5 \\\/var\\\/www\\\/nextcloud\\\/apps\\\/dav\\\/appinfo\\\/v1\\\/webdav.php(76): Sabre\\\\DAV\\\\Server->exec()\\n#6 \\\/var\\\/www\\\/nextcloud\\\/remote.php(162): require_once('\\\/var\\\/www\\\/nextcl...')\\n#7 {main}\",\"File\":\"\\\/var\\\/www\\\/nextcloud\\\/3rdparty\\\/sabre\\\/dav\\\/lib\\\/DAV\\\/Server.php\",\"Line\":749}",
   "userAgent":"<removed>",
   "version":"12.0.3.3"
}

[blizzz]

Works for me™️ (i.e. cannot reproduce)

Please give a complete report using the template https://raw.github.com/nextcloud/core/master/issue_template.md

[GiantCrocodile]

@blizzz Follow these steps:

1. go into a directory, for example default one 'Videos'
2. click on new > new folder/directory
3. enter name <test>a</test>

You get this exception:

It seems to be related to directories, not files. My description from first post was misleading. Sorry for this!

This happens on a Linux server with Postgresql, Nginx and PHP 7.0 in fpm mode.

[MorrisJobke]

cc @icewind1991 @rullzer @danxuliu

[MorrisJobke]

I could reproduce this by following the latest comment.

[rullzer]

It is because of the final /

Lets take the folder foo and you want to create bar/baz. Internally this is translated to create foo/bar/baz

So we try to get the node foo/bar and create the folder baz in there. But of course foo/bar doens't exist yet.

Long story short. / should not be allowed in file/folder names as it is the default directory separator.