»Share via link« should automatically copy the link to the clipboard

[jancborchardt]

(In the sharing section of the sidebar.) That will make the sharing flow a lot easier.

[go2sh]

Were do you want to hook in? I'm about to create a PR but I'm not familiar with the coding style. I checked the code and thought about adding a function to the this.model.on('change:linkShare',..) callback or even into the render function. https://github.com/nextcloud/server/blob/master/core/js/sharedialoglinkshareview.js#108

[jancborchardt]

cc @schiessle and @MorrisJobke for input on @go2sh's question. :)

[Faldon]

As far as I could see (was playing the whole day with this issue), your proposed hook is the only way to go @go2sh . I can grab the link in the shareitem model, but a) I'd rather not have displaying stuff in the model code and b) I was not able to select the text for copying.
Unfortunately I am stuck here. I wanted to use the commandExecute('copy') function, but it seems to be allowed only after a user-generated event.
What would be the way to go here?

[go2sh]

There is anouter commandExecute('selectAll'). As far as I understand the docs, it selects all text in an editable region. This should solve the selecting problem. So the following could be done:

• Let the render finish
• Focus the text field
• commandExecute('selectAll')
• commandExecute('copy')

Alternative there is a jquery function called .select() which should select all text as the jquery docs show https://api.jquery.com/select/.

I'll try to write a small function tomorrow and if it works, I'll create a PR where the rest can be discussed.

[go2sh]

Btw. Part of the code is already there as the text field has a onLinkTextClick event handler which creates the focus and selects the text. :-)

[icewind1991]

see owncloud/core#25418

[go2sh]

I was done with that too plus the autocopy. I though about automatically copying it to clipboard. It might erase content, that the user is not are of. Then you are never able to share a link without thinking about your clipboard. I guess clicking on another button is also acceptable. But I don't mind. Should I submit a PR or do you want to include upstream?

[rullzer]

I think we should wait for owncloud/core#25418 indeed. I do not want autocopy. I should have control over my own clipboard.

[rullzer]

Ok so the clipboard thingy is in. Not the autocopy. I still think that is a bad idea.