E.g.
TypeError
Argument 4 passed to OCA\Comments\Controller\Notifications::__construct() must implement interface OCP\Files\Folder, null given
The problem is, that the UserFolder is returned as null instead of something like e.g. NonExistingFolder
|
$this->registerService(IAppData::class, function (SimpleContainer $c) { |
|
return $this->getServer()->getAppDataDir($c->query('AppName')); |
|
}); |
So either all apps which use Folder injection need to allow = null manually or they will throw if one of the roots is invoked by a guest.
@icewind1991 do you think NonExistingFolder would make sense, or should we just advice all consumers of the app to explicitly allow null or inject IRootFolder instead and get the folder once they are sure it's a logged in user.
E.g.
server/apps/comments/lib/Controller/Notifications.php
Line 75 in 0eebff1
The problem is, that the UserFolder is returned as null instead of something like e.g.
NonExistingFolderserver/lib/private/AppFramework/DependencyInjection/DIContainer.php
Lines 111 to 113 in 0eebff1
So either all apps which use Folder injection need to allow = null manually or they will throw if one of the roots is invoked by a guest.
@icewind1991 do you think
NonExistingFolderwould make sense, or should we just advice all consumers of the app to explicitly allow null or inject IRootFolder instead and get the folder once they are sure it's a logged in user.