Allow multiple share links

[schiessle]

Before starting on the implementation of multiple share links I would like to get some feedback from @nextcloud/designers how this should look like.

I already thought about it a little bit and this is my suggestion:

1. Initial share view:

If you click on "create new public link" you get a text input field which is pre-filled with "share link 1", the next one "share link 2", and so on, so that the user can give the link a name.

If the link was created it will look like this, the user sees the new share link, with the '...' menu and again a option to create another public link:

To the '...' menu I would add the two new additional option "rename" and "unshare".

Opionions? cc @jancborchardt

Steps to complete it

• agree on design
• front-end implementation
• back-end implementation
• OCS API implementation
• Tests

[nextcloud-bot]

GitMate.io thinks possibly related issues are #10218 (allow to add a personal note to a share), #10194 (multiple attachments), #10132 (Allow restoring of deleted user shares), #1639 (Unable to access public shared link), and #3243 (Share by single file with multiple links.).

[MariusBluem]

See discussion and mockups here: #5336

[jancborchardt]

FYI I'm on vacation – please never only @-mention me, always the whole @nextcloud/designers team. :)

As for the design:

• The current way for the first link should stay like it is, to not clutter the view with extra entries for the most common case.
• When you tap into the share input field, "Add new share link" should be suggested as entry like in @MariusBluem's mockup in the linked issue.

[schiessle]

When you tap into the share input field, "Add new share link" should be suggested as entry like in @MariusBluem's mockup in the linked issue.

And the link, after it was created, looks then the same way as the first one (with the checkbox and so on). Do they all have the same name? Or do you just add a number? How will people distinguish the different links?

Also on link removal. Unchecking the checkbox will then remove the complete entry as long as there is one more link and if it is the last one we keep the entry and just uncheck it so that the user can again create the first public link?

Not sure if I understand it completely but sounds quite clumsy and more complicated then what I suggested.

Btw, your mockup here looks quite similiar to what I suggested: #5336 (comment) You also have always a "new share link" action on the top and below the existing shares, including already created public links.

[MariusBluem]

You should definitely be able to give share links a name (maybe we should make this mandatory at all ...)

[tobiasKaminsky]

maybe we should make this mandatory at all

I am unsure how many sharing links are done on one file, but if you only have one, there is no need to have a name for it (of course you should be able to name it, if you want).

[schiessle]

You should definitely be able to give share links a name (maybe we should make this mandatory at all ...)

I agree, that's why my mockup gives you directly a input field, where you can just press enter or focus out to accept the default or give it a custom name without a lot of hassle.