Share link not visible because of ad blockers

[TecJon]

Steps to reproduce

1. Click on share symbol for file or folder
2. Check out side panel for sharing
3. Miss share link option

Expected behaviour

I expect an option to share a link.

Actual behaviour

Only input for user sharing is visible

Server configuration

Nextcloud version: 14.0.0 Beta 1

Updated from an older Nextcloud/ownCloud or fresh install: fresh

Where did you install Nextcloud from:

Signing status:

Signing status

No errors have been found.

Are you using external storage, if yes which one: no

Are you using encryption: no

Are you using an external user-backend, if yes which one: no

Client configuration

Browser: Firefox 61.0.1 (64-bit)

Operating system: Win 10

Logs

Browser log

Browser log

Content Security Policy: Directive ‘child-src’ has been deprecated. Please use directive ‘worker-src’ to control workers, or directive ‘frame-src’ to control frames respectively.
JQMIGRATE: Migrate is installed, version 1.4.0 core.js:7:542
Content Security Policy: The page’s settings blocked the loading of a resource at https://cloud.example.com/index.php/apps/files/ (“script-src”).
<script> source URI is not allowed in this document: “https://cloud.example.com/apps/notifications/js/notifications.js?v=1f8ad6d7-0”. files:51
unreachable code after return statement[Learn More] merged.js:1494:4
window.controllers/Controllers is deprecated. Do not use it for UA detection. merged.js:2171
New search handler registered search.js:66:4
querying Whats New data was successful: nocontent merged-template-prepend.js:4455:4
undefined  merged-template-prepend.js:4456:4

[rullzer]

@nextcloud/javascript seems like some glitch...

[skjnldsv]

Wut!

[skjnldsv]

I cannot reproduce:

Browser: Firefox 61.0.1 (64-bit)

@TecJon can you clear your caches?

[TecJon]

@skjnldsv uBlock Origin was evildoer. When enabled it will not show up (even though reportedly 0% of the page is blocked). Might still be worth looking into?

[skjnldsv]

@TecJon What is the filter blocking this? A custom one?
Because I also have ublock origin (default settings) and it still shows :)

[TecJon]

It seems like the option "Parse and enforce cosmetic filters" is the reason. I'm guessing this filter is not enabled in your environment, @skjnldsv ?

This option enables the parsing and enforcing of Adblock Plus-compatible “element hiding” filters. These filters are essentially cosmetic, they serve to hide elements in a web page which are deemed to be a visual nuisance, and which can't be blocked by the net request-based filtering engine.

I guess that is why it says 0% is blocked. It's not a net request-based filtering.

[skjnldsv]

I do not have this option available, where do you find this?

[TecJon]

I find it in the filter lists tab of the ublock origin settings.
See this screenshot from their github page. Mine looks slightly different and the tabs name is "Filter lists" instead of "3rd-party filters" but the location is the same.
I know I added some filters which were not selected by default. I do not use any custom filters.

[skjnldsv]

Nope, I can't reproduce. All of my settings are already enabled and the parse and enforce cosmetic filters too. :/

@nextcloud/designers can one of you reproduce?

[blizzz]

Cannot reproduce either with uBock origin enabled.

[skjnldsv]

Sorry @TecJon
Thanks a lot for reporting, let's close this one and see if people complains as well (you're the only one so far)
Let's hope this is something unrelated :)