Fix event dispatcher usage - #1045
Merged
Merged
Conversation
4 tasks
Member
Author
|
Branched off stable-2.5 after talking to icewind |
nickvergessen
force-pushed
the
bugfix/noid/fix-event-dispatcher-usage
branch
from
August 28, 2023 12:54
c837262 to
de60c65
Compare
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
…anch Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/noid/fix-event-dispatcher-usage
branch
from
August 28, 2023 12:55
de60c65 to
bc723b1
Compare
icewind1991
approved these changes
Aug 28, 2023
icewind1991
left a comment
icewind1991
left a comment
Member
There was a problem hiding this comment.
Basic functionality still seems to work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app breaks on master due to the unavoidable changes in the event dispatcher handling with the upcoming symfony update.