This repository was archived by the owner on Nov 1, 2020. It is now read-only.
Only load scripts on the files and sharing pages - #181
Merged
Conversation
Member
|
Hold on I thought we had this new way of asking Files to load scripts (loadAdditionalScript or something). Wouldn't that be a better solution? |
Member
Author
|
Yes, if that is enough use that: |
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
only-load-scripts-on-files-and-sharing
branch
from
December 5, 2016 08:37
c61f03e to
c90564f
Compare
Member
Author
|
Updated, for better diff see https://github.com/nextcloud/gallery/pull/181/files?w=1 |
Current coverage is 99.74% (diff: 100%)@@ master #181 diff @@
==========================================
Files 39 39
Lines 1201 1197 -4
Methods 170 170
Messages 0 0
Branches 0 0
==========================================
- Hits 1198 1194 -4
Misses 3 3
Partials 0 0
|
Member
|
Thanks for the update, the only thing missing is the same thing for public pages. @rullzer had added it to 10 I think. |
Signed-off-by: Joas Schilling <coding@schilljs.com>
Member
Author
|
I thought that was the same, but It only has a similar name. Fixed. |
Member
|
Ah yes we can do that now that oC support is gone. 👍 |
rullzer
approved these changes
Jan 5, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref nextcloud/server#2448
Licence: AGPL
@oparoz