"Upload new icon" doesn't work

[djohannes]

Steps to reproduce

1. Install "external sites"
2. Go to Administration settings -> External sites
3. Click on "Upload new icon"

Expected behaviour

It should open the file picker to upload a new logo

Actual behaviour

nothing

Server configuration

Nextcloud AIO v13.2.1 with the default settings (except that I checked the checkbox to install the latest 34 version)
I didn't install any other apps yet or changed anything in the settings. It's a fresh install, I went straight to the Apps to install "external" and run into this.

Nextcloud version: 34.0.0

Browser

Chrome 149.0.7827.102 on Windows, also didn't work on Safari with iOS 26

[AkalaAkala]

Having the same issue in v34

[AkalaAkala]

I have a workaround:

1. Place your SVG in /appdata_XXXXX/external/icons in your Nextcloud data directory.

2. Then run docker exec -u www-data nextcloud-aio-nextcloud php occ files:scan-app-data in SSH, and the icon will show when you refresh the page.

[cookie-monster1649]

Can replicate in 34.0.1 too

[julien6499]

I'm hitting the same issue on Nextcloud 34.0.1, External sites 9.0.1.
Steps to reproduce:

1. Go to Settings → Administration → External sites
2. Click the "Upload new icon" button (aria-label="Téléverser une nouvelle icône" in French locale) for an existing site

Result: nothing happens — no file picker opens, no network request is fired, and no error appears in the browser console, even on page load and even in a private/incognito window (ruling out cache or extensions).

Root cause (found by inspecting the DOM/event listeners):
The upload button markup looks like this:

<form class="upload-button">
  <input id="uploadicon" class="hidden-upload-input" type="file" accept="image/*">
  <label for="uploadicon">
    <button class="button-vue ..." type="button" aria-label="...">...</button>
  </label>
</form>

The hidden <input type="file"> is meant to be triggered natively via the surrounding <label for="uploadicon">. However, the <button> inside is an NcButton (@nextcloud/vue) with its own click listener attached directly to it (confirmed via Chrome DevTools' Event Listeners panel with "Ancestors" unchecked). It looks like this internal handler calls preventDefault() (or otherwise swallows the event), which blocks the native label → input forwarding before it ever reaches the hidden input — hence no file picker, no request, no error.

Workaround:
Triggering the hidden input directly, bypassing the button/label, works fine:

document.getElementById('uploadicon').click()

Run this in the browser console while on the External sites settings page — it opens the native file picker immediately, and the upload then proceeds normally (network request fires, icon gets saved).
For convenience, this can be turned into a bookmarklet (a browser bookmark with this as the URL):

javascript:document.getElementById('uploadicon').click()

Clicking it while on the External sites settings page reopens the file picker without needing to open the console each time.

Hope this helps narrow down the fix — happy to provide more details (screenshots of the Event Listeners panel, etc.) if useful.