OCA\\Deck\\Db\\CardMapper::findBoardId(): Return value must be of type ?int, string returned

[Czujackt]

Describe the bug
When I want to add a file to a deck card this error comes up.

Client details:

• OS: macOS
• Browser: Safari / Chrome
• Version: 21.0.5
• Device: desktop

Operating system:
Linux

Web server:
apache

Database:
mysql

PHP version:
8

Logs

Nextcloud log (data/nextcloud.log)

{"reqId":"AX8Ekx0xFJ6WMJixvQs2","level":3,"time":"2021-10-25T10:50:55+02:00","remoteAddr":"","user":"","app":"deck","method":"POST","url":"/index.php/apps/deck/cards/1341/attachment","message":{"Exception":"Exception","Message":"OCA\\Deck\\Db\\CardMapper::findBoardId(): Return value must be of type ?int, string returned","Code":0,"Trace":[{"file":"/mnt/data/www/nextcloud/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/mnt/data/www/nextcloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/mnt/data/www/nextcloud/lib/base.php","line":993,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/mnt/data/www/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::"}],"File":"/mnt/data/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","Line":159,"Previous":{"Exception":"TypeError","Message":"OCA\\Deck\\Db\\CardMapper::findBoardId(): Return value must be of type ?int, string returned","Code":0,"Trace":[{"file":"/mnt/data/www/nextcloud/apps/deck/lib/Sharing/DeckShareProvider.php","line":108,"function":"findBoardId","class":"OCA\\Deck\\Db\\CardMapper","type":"->"},{"file":"/mnt/data/www/nextcloud/lib/private/Share20/Manager.php","line":806,"function":"create","class":"OCA\\Deck\\Sharing\\DeckShareProvider","type":"->"},{"file":"/mnt/data/www/nextcloud/apps/deck/lib/Service/FilesAppService.php","line":206,"function":"createShare","class":"OC\\Share20\\Manager","type":"->"},{"file":"/mnt/data/www/nextcloud/apps/deck/lib/Service/AttachmentService.php","line":200,"function":"create","class":"OCA\\Deck\\Service\\FilesAppService","type":"->"},{"file":"/mnt/data/www/nextcloud/apps/deck/lib/Controller/AttachmentController.php","line":71,"function":"create","class":"OCA\\Deck\\Service\\AttachmentService","type":"->"},{"file":"/mnt/data/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":218,"function":"create","class":"OCA\\Deck\\Controller\\AttachmentController","type":"->"},{"file":"/mnt/data/www/nextcloud/lib/private/AppFramework/Http/Dispatcher.php","line":127,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/mnt/data/www/nextcloud/lib/private/AppFramework/App.php","line":157,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->"},{"file":"/mnt/data/www/nextcloud/lib/private/Route/Router.php","line":302,"function":"main","class":"OC\\AppFramework\\App","type":"::"},{"file":"/mnt/data/www/nextcloud/lib/base.php","line":993,"function":"match","class":"OC\\Route\\Router","type":"->"},{"file":"/mnt/data/www/nextcloud/index.php","line":37,"function":"handleRequest","class":"OC","type":"::"}],"File":"/mnt/data/www/nextcloud/apps/deck/lib/Db/CardMapper.php","Line":552},"CustomMessage":"--"},"userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/605.1.15 (KHTML, like Gecko) Version/15.0 Safari/605.1.15","version":"21.0.5.1"}

Browser log

Failed to load resource: the server responded with a status of 500 ()

[Czujackt]

I came across the following query while searching for this problem:

'SELECT id FROM *PREFIX*deck_boards WHERE id IN (SELECT board_id FROM *PREFIX*deck_stacks WHERE id IN (SELECT stack_id FROM *PREFIX*deck_cards WHERE id = ?))'.

Why do this?
The last SELECT: 'SELECT id FROM ... WHERE id' is not necessary.

Use this:
'SELECT board_id as id FROM *PREFIX*oc_deck_stacks WHERE id IN (SELECT stack_id FROM *PREFIX*oc_deck_cards WHERE id = ?)

[Czujackt]

I have now updated to Nextcloud 22 and now the bug is no longer there.

However, the query is still there

[Czujackt]

After it worked for one day, now the same error is back.

[Czujackt]

After it worked for one day, now the same error is back.

If I restart redis then it works again.

[juliusknorr]

Can you share a full issue template, especially with details about the deck and mysql version? I'd expect that the database abtraction would properly return an integer there already.

[Czujackt]

Deck Version 1.5.3
Nextcloud Version 22.2.0
mysql Version 8.0.25
php Version 8.0.12

I have changed the 'memcache.local' => '\OC\Memcache\Memcached' to memcached.
After this change I had no more problems until now.

I think that the problem is very much related to redis

[joshtrichards]

Similar to #4637
Fixed in #4765