upload attachment with already existing filename

[rms-joe]

Describe the bug
if u try to reupload an attachment without changing filename,
it doesn't get executed without further notification.

To Reproduce
Steps to reproduce the behavior:

1. create a text document
2. upload doc to card
3. change doc content, save locally without changing filename
4. upload again to card

browser:
only way to see, that file isn't uploaded, is checking upload time

android app:
file already exists notification

Expected behavior
file gets updated,
or
a noticeable notification that file isn't uploaded: "file already exists"

Nextcloud Deck version:
1.0.0

[jakobroehrl]

Can't reproduce it.
On the latest master a message is shown:

But I realized the overwrite is not working

[juliusknorr]

1.0.0

Might have been fixed in the meantime.

@jakobroehrl Still mind to address the overwrite issue and the placeholder {filename} not being inserted in the dialog?

[stefan-niedermann]

Sorry for side question: How can one force an overwrite? I think the REST endpoint just threw some kind of bad request status code ... Is there an optional url parameter or so?

[juliusknorr]

The conflict should only appear on sending a POST to /api/v1.0/boards/{boardId}/stacks/{stackId}/cards/{cardId}/attachments. To update the existing attachment id would be added to the route:

/boards/{boardId}/stacks/{stackId}/cards/{cardId}/attachments/{attachmentId}

However quickly looking at the existing docs I'm not sure if that works since it uses a PUT method, and as a far as I remember file uploading was not working through that.

[juliusknorr]

Might be that we need to support POST on the update route for the api then as well

deck/appinfo/routes.php

Lines 73 to 74 in 3c6a177

	// also allow to use POST for updates so we can properly access files when using application/x-www-form-urlencoded
	['name' => 'attachment#update', 'url' => '/cards/{cardId}/attachment/{attachmentId}', 'verb' => 'POST'],

[stefan-niedermann]

Shall i open a new issue for that or will you handle it within this issue?

[juliusknorr]

A separate one would be awesome since this one is mainly frontend related.

[jakobroehrl]

1.0.0

Might have been fixed in the meantime.

@jakobroehrl Still mind to address the overwrite issue and the placeholder {filename} not being inserted in the dialog?

Sure.
Found the problem in the meantime: The File already exists dialog showes up only on drag and drop upload files.

[rms-joe]

Found the problem in the meantime: The File already exists dialog showes up only on drag and drop upload files.

Confirm. I didn't use drag and drop.
Tbh, I didn't know it's possible.
A hint (Box 'drag and drop files here) is missing,
or to be more precise, is only displayed while doing exactly that.