fix: hide invitation reply buttons on cancelled event

[madbob]

Do not include InvitationResponseButtons if the event has been cancelled, and add a "This event was cancelled" notice also in EditFull (copied from EditSimple).

Note: changes to the close button for mobile were required to properly accomodate the textual notice.

Fixes #4420

[SebastianKrupinski]

Hi @madbob

Thanks for the PR, but there are a couple of issues with it

[SebastianKrupinski]

This seems unrealted

[SebastianKrupinski]

These changes also seem unrelated

[SebastianKrupinski]

@madbob I see you addressed the editor mixins' but why do we need the css changes?

[madbob]

The reasons of CSS changes lies in

.app-full__header__top__first {
  flex-direction: column;
}

added to apply a vertical layout to the header (and have the "event cancelled" notice below the title).

Keeping visibility: hidden to the "Close" button, it still occupies space in the page (even if invisible) and this alters the alignment of the whole block with the block aside (the one with Save/Update buttons).

Changing it to display: none the "Close" button doesn't allocate space when hidden.

[codecov]

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/mixins/EditorMixin.js	0.00%	2 Missing ⚠️

📢 Thoughts on this report? Let us know!

[SebastianKrupinski]

The reasons of CSS changes lies in

.app-full__header__top__first {
  flex-direction: column;
}

Hard to see what you are trying to address without context

Before CSS:

After CSS:

[SebastianKrupinski]

@madbob

I am not crazy about the design choice, the wording is in the wrong place and not very visible.

Lets keep the PR to "fix: hide invitation reply buttons on cancelled event" and you can make another PR to "feat: indicate cancelled event" because we'll need to get design involved for those changes.

[madbob]

Ok.

I just want to point out that EditSimple has not been changed (I've moved the definition of isCancelled, but nothing in contents nor in CSS. Including the "This event was cancelled" notice, which was already there), all visual changes are in EditFull.

Here a more complete comparison screenshot (I had to provide it before... :-\ ).

[SebastianKrupinski]

Ok.

I just want to point out that EditSimple has not been changed (I've moved the definition of isCancelled, but nothing in contents nor in CSS. Including the "This event was cancelled" notice, which was already there), all visual changes are in EditFull.

Well that is interesting because the screen captures where with and without your code.

[SebastianKrupinski]

/backport to stable6.6

[SebastianKrupinski]

/backport to stable6.5