refactor: remaining appointment booking components to typescript and … - #8865
Draft
SebastianKrupinski wants to merge 1 commit into
Draft
refactor: remaining appointment booking components to typescript and …#8865SebastianKrupinski wants to merge 1 commit into
SebastianKrupinski wants to merge 1 commit into
Conversation
…composition api Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
odzhychko
approved these changes
Sep 9, 2026
odzhychko
left a comment
odzhychko
left a comment
Contributor
There was a problem hiding this comment.
Code looks good and works as expected.
The ESLint error can be easily fixed.
| import autosize from '@/directives/autosize.js' | ||
| import { timeStampToLocaleDate, timeStampToLocaleTime } from '@/utils/localeTime.js' | ||
|
|
||
| const vAutosize = autosize |
Contributor
There was a problem hiding this comment.
note: vAutosize can be removed.
It was not used before the refactoring.
It was probably used on the text field of the description before it was migrated toNcTextArea.
NcTextArea has the resize="vertical" set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…composition api
🤖 AI (if applicable)