Skip to content

fix(ProposalService): proposal creation - #8092

Merged
SebastianKrupinski merged 1 commit into
mainfrom
fix/meeting-proposal-creation
Mar 30, 2026
Merged

fix(ProposalService): proposal creation#8092
SebastianKrupinski merged 1 commit into
mainfrom
fix/meeting-proposal-creation

Conversation

@GVodyanov

Copy link
Copy Markdown
Contributor

Fix #8049

I don't know much backend so if someone who knows this stuff better could review it, it would be appreciated.

@GVodyanov GVodyanov self-assigned this Mar 25, 2026
@GVodyanov GVodyanov added the 3. to review Waiting for reviews label Mar 25, 2026
@GVodyanov
GVodyanov requested a review from tcitworld as a code owner March 25, 2026 10:42
@GVodyanov
GVodyanov force-pushed the fix/meeting-proposal-creation branch from f260373 to 8120fda Compare March 25, 2026 10:43
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

I'll look at it next week

@GVodyanov
GVodyanov force-pushed the fix/meeting-proposal-creation branch from 8120fda to 4b1d2f4 Compare March 25, 2026 10:51

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

did not test

@SebastianKrupinski
SebastianKrupinski force-pushed the fix/meeting-proposal-creation branch from 4b1d2f4 to 2dee7b6 Compare March 30, 2026 16:22
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

@GVodyanov

Right approach, but you can just reuse the existing functions (pushed the change).

Signed-off-by: Grigory V <scratchx@gmx.com>
@SebastianKrupinski
SebastianKrupinski force-pushed the fix/meeting-proposal-creation branch from 2dee7b6 to 86de53e Compare March 30, 2026 16:26
@SebastianKrupinski

Copy link
Copy Markdown
Contributor

/backport to stable6.2

@backportbot backportbot Bot added the backport-request A backport was requested for this pull request label Mar 30, 2026
@codecov

codecov Bot commented Mar 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@SebastianKrupinski
SebastianKrupinski merged commit 5e3a486 into main Mar 30, 2026
42 checks passed
@SebastianKrupinski
SebastianKrupinski deleted the fix/meeting-proposal-creation branch March 30, 2026 16:31
@backportbot backportbot Bot removed the backport-request A backport was requested for this pull request label Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Cannot confirm/create meeting from accepted Talk Meeting Proposal — error on confirmation

4 participants