Improve chunked upload - #17508
Open
alperozturk96 wants to merge 9 commits into
Open
Conversation
4 tasks
|
APK file: https://github.com/nextcloud/android/actions/runs/32365738081/artifacts/9405404973 |
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me> # Conflicts: # app/src/main/java/com/owncloud/android/operations/UploadFileOperation.java
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
alperozturk96
force-pushed
the
improve-chunked-upload
branch
from
September 1, 2026 08:11
7ee13b7 to
3a3e569
Compare
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
Signed-off-by: alperozturk96 <alper_ozturk@proton.me>
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
daniele-verducci
approved these changes
Sep 1, 2026
daniele-verducci
left a comment
daniele-verducci
left a comment
Contributor
There was a problem hiding this comment.
Hey Alper, I tested:
- file under server's advertised chunk size in normal folder
- file over server's advertised chunk size in normal folder (uses chunked upload)
- file under server's advertised chunk size in encrypted folder
- file over server's advertised chunk size in encrypted folder (uses chunked upload)
Works flawlessly.
Tried to test the upload on slow connection as reported in the issue, I used the emulator's trottling, works but in that case also the current stable worked for me so not much to compare there...
Checked the code and seems nice to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Library: nextcloud/android-library#2117
Fixes: #17469