Skip to content

Initial work on v2 with activity - #361

Merged
tobiasKaminsky merged 9 commits into
masterfrom
v2withActivity
Dec 11, 2019
Merged

Initial work on v2 with activity#361
tobiasKaminsky merged 9 commits into
masterfrom
v2withActivity

Conversation

@tobiasKaminsky

@tobiasKaminsky tobiasKaminsky commented Nov 29, 2019

Copy link
Copy Markdown
Member

This uses new dav4jvm, but also old httpclient in parallel.
I changed GetActivityRemoteOperation, as this is no critical remoteOperation.

Signed-off-by: tobiasKaminsky tobias@kaminsky.me

Comment thread README.md
Comment thread src/main/java/com/owncloud/android/lib/common/OwnCloudClientFactory.java Outdated
Comment thread src/main/java/com/owncloud/android/lib/common/operations/RemoteOperation.java Outdated
Comment thread src/main/java/com/owncloud/android/lib/common/operations/RemoteOperation.java Outdated
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

TypemasterPR
Warnings00
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings37
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings58
Total160

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings59
Total163

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

TypemasterPR
Warnings00
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings37
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings58
Total160

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings59
Total163

@codecov

codecov Bot commented Dec 10, 2019

Copy link
Copy Markdown

Codecov Report

Merging #361 into master will increase coverage by 0.97%.
The diff coverage is 28.44%.

@@            Coverage Diff             @@
##           master     #361      +/-   ##
==========================================
+ Coverage   31.81%   32.79%   +0.97%     
==========================================
  Files         120      123       +3     
  Lines        5286     5486     +200     
  Branches      704      732      +28     
==========================================
+ Hits         1682     1799     +117     
- Misses       3380     3438      +58     
- Partials      224      249      +25
Impacted Files Coverage Δ
.../lib/resources/shares/GetShareRemoteOperation.java 0% <ø> (ø) ⬆️
...ources/shares/GetSharesForFileRemoteOperation.java 0% <ø> (ø) ⬆️
...om/owncloud/android/lib/common/OwnCloudClient.java 38.18% <ø> (-0.38%) ⬇️
...b/resources/shares/UpdateShareRemoteOperation.java 0% <ø> (ø) ⬆️
...b/resources/shares/CreateShareRemoteOperation.java 67.34% <ø> (-0.66%) ⬇️
...d/lib/resources/files/MoveFileRemoteOperation.java 0% <ø> (ø) ⬆️
...lib/resources/shares/GetSharesRemoteOperation.java 68.18% <ø> (-1.39%) ⬇️
...droid/lib/common/OwnCloudAnonymousCredentials.java 55.55% <0%> (-6.95%) ⬇️
...d/android/lib/common/OwnCloudBasicCredentials.java 47.61% <0%> (-2.39%) ⬇️
...loud/android/lib/resources/OCSRemoteOperation.java 54.54% <0%> (-45.46%) ⬇️
... and 28 more

@AndyScherzinger

Copy link
Copy Markdown
Member

@tobiasKaminsky needs rebase and is good to go then

tobiasKaminsky and others added 6 commits December 11, 2019 09:37
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
use correct user agent

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
methods call from constructor should be final

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
…(nextcloudClient)

Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
… [skip ci]

Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Codacy Here is an overview of what got changed by this pull request:

Complexity decreasing per file
==============================
+ src/main/java/com/owncloud/android/lib/resources/notifications/DeleteNotificationRemoteOperation.java  -1
+ src/main/java/com/owncloud/android/lib/resources/notifications/DeleteAllNotificationsRemoteOperation.java  -1
+ src/main/java/com/owncloud/android/lib/resources/notifications/GetNotificationsRemoteOperation.java  -1
         

Clones removed
==============
+ src/main/java/com/owncloud/android/lib/resources/shares/GetShareRemoteOperation.java  -1
+ src/main/java/com/owncloud/android/lib/resources/shares/GetSharesRemoteOperation.java  -1
         

See the complete overview on Codacy

@nextcloud-android-bot

Copy link
Copy Markdown
Collaborator

Lint

TypemasterPR
Warnings00
Errors00

SpotBugs (new)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings37
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings58
Total160

SpotBugs (master)

Warning TypeNumber
Bad practice Warnings15
Correctness Warnings39
Internationalization Warnings6
Malicious code vulnerability Warnings7
Multithreaded correctness Warnings3
Performance Warnings17
Security Warnings17
Dodgy code Warnings59
Total163

@tobiasKaminsky
tobiasKaminsky merged commit abb428f into master Dec 11, 2019
@delete-merged-branch
delete-merged-branch Bot deleted the v2withActivity branch December 11, 2019 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants