Initial work on v2 with activity - #361
Merged
Merged
Conversation
tobiasKaminsky
force-pushed
the
v2withActivity
branch
from
November 29, 2019 07:36
e124dca to
0ea01d2
Compare
1 task
tobiasKaminsky
force-pushed
the
v2withActivity
branch
from
November 29, 2019 08:56
f620d31 to
467672a
Compare
tobiasKaminsky
force-pushed
the
v2withActivity
branch
from
November 29, 2019 09:32
467672a to
0a86b3a
Compare
Collaborator
|
IT test failed: https://www.kaminsky.me/nc-dev/library-integrationTests/1311 |
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
previously approved these changes
Dec 10, 2019
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
==========================================
+ Coverage 31.81% 32.79% +0.97%
==========================================
Files 120 123 +3
Lines 5286 5486 +200
Branches 704 732 +28
==========================================
+ Hits 1682 1799 +117
- Misses 3380 3438 +58
- Partials 224 249 +25
|
Member
|
@tobiasKaminsky needs rebase and is good to go then |
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
use correct user agent Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
methods call from constructor should be final Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
…(nextcloudClient) Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
… [skip ci] Signed-off-by: nextcloud-android-bot <android@nextcloud.com>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
Signed-off-by: tobiasKaminsky <tobias@kaminsky.me>
tobiasKaminsky
force-pushed
the
v2withActivity
branch
from
December 11, 2019 08:37
a0852d9 to
bb31f9b
Compare
Collaborator
|
Complexity decreasing per file
==============================
+ src/main/java/com/owncloud/android/lib/resources/notifications/DeleteNotificationRemoteOperation.java -1
+ src/main/java/com/owncloud/android/lib/resources/notifications/DeleteAllNotificationsRemoteOperation.java -1
+ src/main/java/com/owncloud/android/lib/resources/notifications/GetNotificationsRemoteOperation.java -1
Clones removed
==============
+ src/main/java/com/owncloud/android/lib/resources/shares/GetShareRemoteOperation.java -1
+ src/main/java/com/owncloud/android/lib/resources/shares/GetSharesRemoteOperation.java -1
See the complete overview on Codacy |
Collaborator
Lint
SpotBugs (new)
SpotBugs (master)
|
AndyScherzinger
approved these changes
Dec 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses new dav4jvm, but also old httpclient in parallel.
I changed GetActivityRemoteOperation, as this is no critical remoteOperation.
Signed-off-by: tobiasKaminsky tobias@kaminsky.me