Handle optional NXDL dimensions during validation - #269
Conversation
|
Thank you for the PR, which is very timely, since I want to raise the variable dimensions issues at the NIAC meeting next week. It looks fine, but I need to run a couple of tests before approving. |
|
I have made a number of other changes to the validation tools, including the addition of two new scripts, You might also be interested in changes I have proposed to the NeXus definitions (nexusformat/definitions#1664), which I believe clean up some of the issues surrounding dimension symbols in NXDL files. This has been discussed at the NIAC, but not approved yet. |
Summary
requiredattribute when converting XML definitionsfalseor0)requiredattribute is omitted or trueCloses #248.
Verification
pytest tests/test_validate.py -vv(6 passed)pytest --basetemp <E: scratch directory>(113 passed)ruff check src/nexusformat/nexus/utils.py src/nexusformat/nexus/validate.py tests/test_validate.pynxcheck --helpentry pointDisclosure: This change was developed with assistance from OpenAI Codex and reviewed and verified by CAOShurong.