Repository navigation
fix: name the distribution litegrip-python - #72
Merged
Merged
Conversation
Align the distribution name with the repository and the PyPI project, as litearm-python does, so the trusted publisher can create the project. The import package stays litegrip; only the install name changes. Update the version lookup, the optional-extra hints, both READMEs and the examples, and add a test that keeps the manifest and runtime names in sync.
|
🎉 This PR is included in version 1.1.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Align litegrip with the naming used by litearm-python: repository, distribution and PyPI project all use the same name. The distribution becomes
litegrip-pythonwhile the import package stayslitegrip.This matches a pending publisher configured for
litegrip-python. If the PyPI pending publisher uses another name, it must be changed tolitegrip-python; otherwise the first upload will fail the same way v1.1.1 did.Do not re-run the failed v1.1.1 publish job: its artifacts are built as
litegrip. Thisfix:commit produces a new release whose artifacts arelitegrip_python-*.Changes
pyproject.toml:name = "litegrip-python"._detect_version()reads thelitegrip-pythondistribution.litegrip-python[zenoh].Testing
Result:
Ran 467 tests in 10.828s—OK.Built a wheel and checked its metadata:
Result:
Installed the wheel into a clean venv and confirmed the version lookup finds the new distribution name:
Issues
No linked issue.