Skip to content

Use generic optional type instead of pointers for changeset #3

Open

Description

@hlubek

Bulding pointers to pointers can be tricky and need some extra lines of code.

We could use a generic Optional type behind some command flag:

type Optional[T any] struct {
	Valid bool
	Value T
}

func NewValidOptional[T any](value T) Optional[T] {
	return Optional[T]{
		Valid: true,
		Value: value,
	}
}

func NewEmptyOptional[T any]() Optional[T] {
	return Optional[T]{
		Valid: false,
	}
}

func init() {
	v1 := NewValidOptional(uuid.Nil)
	v2 := NewEmptyOptional[uuid.UUID]()
	
}

Activity

  1. hlubek commented on Apr 12, 2023

    @hlubek
    ContributorAuthor

    Idea: generate chainable API (e.g. WithID(id uuid.UUID)) that takes care of taking the pointer.
    If a field is a pointer value (e.g. *time.Time), we could generate a WithMyFieldValue(value time.Time) method that sets the pointer to a pointer to a time.Time in the changeset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions