FileUpload: fix getters calls on empty FileUpload - #195
Closed
EdaCZ wants to merge 11 commits into
Closed
Conversation
dg
force-pushed
the
master
branch
4 times, most recently
from
April 27, 2021 21:33
6ee31b8 to
4f4a403
Compare
dg
force-pushed
the
master
branch
4 times, most recently
from
August 25, 2021 15:26
a8895b6 to
9409a5f
Compare
dg
force-pushed
the
master
branch
8 times, most recently
from
September 3, 2021 22:27
a85dc37 to
12e2e54
Compare
dg
force-pushed
the
master
branch
3 times, most recently
from
October 13, 2022 01:29
59f402a to
32af756
Compare
dg
force-pushed
the
master
branch
12 times, most recently
from
November 30, 2022 17:29
ba7eba8 to
7774190
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
December 5, 2022 00:09
c6e0524 to
788ddc4
Compare
dg
force-pushed
the
master
branch
2 times, most recently
from
January 15, 2023 17:08
0f24022 to
ebdb825
Compare
dg
force-pushed
the
master
branch
7 times, most recently
from
January 24, 2023 19:09
684be2b to
2a0c595
Compare
Member
|
fixed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happened to me recently: I forgot to mark form item with file upload as mandatory, so users were able to send form without any file. But on backend I have complex system of validators, which want to validate name, size etc. Validators are build using composition and each of them do just one thing (for example one of them just calls
getName(newlygetSanitizedName/getUntrustedName) on receivedFileUploadand checks its name...). It's not really handy to repeat in each of them condition with$file->isOk()... But if I didn't have it there, it would crash on the error:Return value of Nette\Http\FileUpload::getName() must be of the type string, null returned(in PHP 7.3), because properties don't have default values andnullis not compatible with typehintstring...I believe that getters should be callable without an error even on empty file upload, to make behavior of our
FileUploadmore predictable and consistent.I tried to add failing test and fix it.
I hope it's ok for you, just let me know if some changes needed.
Thanks.