Skip to content

The package is blocked by Roave/SecurityAdvisories based on CVE-2024-55586 #314

Open

Description

@jkavalik

Advisory link - GHSA-f626-677r-j5vq
What I suppose was the "source" - https://www.csirt.sk/nette-framework-vulnerability-permits-sql-injection.html

Result - all versions other than 4.0 RC are disallowed.

Imho the app allowing unfiltered user input into the DB library is the definition of app bug, not library bug, and the "vulnerability" designations seems nonsense to me, but I am no security expert.

Activity

  1. mfn commented on Dec 10, 2024

    @mfn

    Wow, this is such a shitshow.

    Now this, last week there was also a similar thing -> Roave/SecurityAdvisories#137 (comment)

    Granted, I'm not associated with either and the final verdict has not been spoken yet as to the validity of the claims, but being cautious here I too think the claim as presented on the external link page is not correct.

  2. dg commented on Dec 10, 2024

    @dg
    Member

    I found emails that they wrote to me about this. So I replied to them that it’s not a bug, that this behavior is intentional and is also documented. However, I have no idea if it’s possible to revoke such a CVE.

  3. mfn commented on Dec 10, 2024

    @mfn

    The real travesty is that it seems anyone can publish any CVE for any package, without maintainer acknowledgement, but then you need to proof they're not valid etc. Something isn't right here.

  4. spaze commented on Dec 11, 2024

    @spaze
    Contributor

    @dg you can start by "improving" (their word, not mine) the GitHub Security Advisory (GHSA) here https://github.com/advisories/GHSA-f626-677r-j5vq/improve

    Once/if the GHSA will be invalidated, Roave/SecurityAdvisories will/should stop blocking the installation (and the same for composer audit).

    Then you can request a CVE rejection here https://cveform.mitre.org/ (Rejected CVE is an official term)

    I wouldn't mind much if the CVE will not be rejected (heard there's a chance it won't, in general for various reasons, not this particular CVE) as long as the GHSA is.

    I would "improve" the GHSA entry but I think it's better when the "improvement" comes from the maintainer, let's see.

  5. jkavalik commented on Dec 13, 2024

    @jkavalik
    Author

    Great, so a "security expert" does not understand basic principles, says something about "spent time" but - THEIR nonsense stopped OUR CI in its tracks for days without any reason whatsoever...

  6. 8ctopus commented on Dec 17, 2024

    @8ctopus

    Any update on when this will be solved? Maybe @dg could release version 3.2.5, this way the block could be removed without waiting for the CVE rejection.

  7. otazniksk commented on Dec 17, 2024

    @otazniksk

    HINT:
    Ignore this CVE in composer.json (temporary ignoring) for unlock

        "config": {
            "audit": {
                "ignore": {
                    "CVE-2024-55586": "Visit https://github.com/nette/database/issues/314"
                }
            }
        },
    
  8. added a commit that references this issue on Dec 17, 2024
  9. spaze commented on Dec 17, 2024

    @spaze
    Contributor

    I have created a PR Roave/SecurityAdvisoriesBuilder#759 to ignore the GHSA/CVE in roave/security-advisories.

  10. spaze commented on Dec 17, 2024

    @spaze
    Contributor

    The PR was merged and roave/security-advisories doesn't block nette/database anymore Roave/SecurityAdvisories@3076981

  11. 8ctopus commented on Dec 17, 2024

    @8ctopus

    @spaze Thank you!

  12. dg commented on Dec 17, 2024

    @dg
    Member

    It sucks that Composer itself started reporting it to me today, so I'll probably release a new version of the package.

  13. xabbuh commented on Dec 17, 2024

    @xabbuh

    @dg you should be able to let Packagist ignore this advisory (see composer/packagist#1493 for such an example)

  14. spaze commented on Dec 19, 2024

    @spaze
    Contributor

    To recap, new 3.2.5 version was released yesterday (thanks @dg!) so composer doesn't complain anymore when installing or running composer audit, roave/security-advisories has the GHSA/CVE excluded so CI pipelines should be green once again, mine are.

    The CVE itself is still in "disputed" status, "Awaiting Analysis".

  15. deleted a comment from dg on Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions