Skip to content

Missing havingOr ? #240

Open
Open

Description

@dakujem

I would like to see method Selection::havingOr implemented, as that feature is missing and cumbersome to achieve.

It should work analogously to the Selection::whereOr method.

Let me know if I could work on this. Also, I'd like to port this feature to the 2.x branch.

Activity

  1. dg commented on Nov 18, 2019

    @dg
    Member

    Yes, please send PR.

  2. dakujem commented on Mar 26, 2020

    @dakujem
    Author

    Well I looked into this issue the other day and found out it would require a deeper rework and a BC break without a doubt.

    This is because in the SqlBuilder class, the "where" conditions are represented as an array of conditions, whereas the "having" conditions are represented as a string.

    And since I know what the attitude to BC breaks (or general overhauls) is, I'd rather work on it once I know there will be support.

  3. dg commented on Mar 26, 2020

    @dg
    Member

    Of course, this new feature should not cause a BC break…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions