refactor: fix types in deploy command and its utils by serhalp · Pull Request #8599 · netlify/cli

serhalp · 2026-10-08T18:08:29Z

Summary

Replace the $TSFixMe/any parameters and @ts-expect-error markers in the deploy command and src/utils/deploy/ with real types.

Remaining gaps in upstream package types are marked with specific FIXME casts or suppressions.

Runtime behaviour is aggressively unchanged in an effort to keep this PR entirely about fixing/adding types.

Weak type pattern	Removed	Added	Net
`any`	24	0	-24
`$TSFixMe` (`any`)	32	0	-32
`@ts-expect-error`	45	6	-39
type assertion (`as`)	14	19	+5
eslint suppressions	273	4	-269

coderabbitai · 2026-10-08T18:08:39Z

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Team
Run ID: f4101271-d52c-476f-98e9-ffa4a3016ffa

📥 Commits

Reviewing files that changed from the base of the PR and between 74f1ee5 and 7ef3169.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI
Review profile: CHILL
Plan: Team
Run ID: 7b5493b5-f1e9-4dcf-9441-d05465f32b28

📥 Commits

Reviewing files that changed from the base of the PR and between e137887 and 74f1ee5.

📒 Files selected for processing (18)

eslint-suppressions.json
src/commands/deploy/deploy.ts
src/lib/spinner.ts
src/utils/deploy/deploy-site.ts
src/utils/deploy/drop-api.ts
src/utils/deploy/file.ts
src/utils/deploy/hash-config.ts
src/utils/deploy/hash-files.ts
src/utils/deploy/hash-fns.ts
src/utils/deploy/hasher-segments.ts
src/utils/deploy/process-files.ts
src/utils/deploy/types.ts
src/utils/deploy/upload-files.ts
src/utils/deploy/upload-source-zip.ts
src/utils/deploy/util.ts
tests/unit/utils/deploy/hash-files.test.ts
tests/unit/utils/deploy/hash-fns.test.ts
tests/unit/utils/deploy/upload-files.test.ts

🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

netlify/blueprints (manual)

💤 Files with no reviewable changes (1)

tests/unit/utils/deploy/hash-files.test.ts

Included review availability: This review used your included allowance. 9 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour. Your free on-demand review promotion remains active until October 9, 2026 at 6:00 PM UTC.

📝 Summary

Summary by CodeRabbit

Improvements
- Deployment workflows now use clearer, more precise handling of deploy details, files, and upload data.
- Uploads support in-memory file content alongside files from disk.
- Deploy progress can be stopped safely when no spinner is available.

Walkthrough

The deploy pipeline now uses more explicit types for configuration, files, API responses, and deploy results. The changes add support for inline upload content, type deploy polling results, and update deploy command handling. ESLint suppression counts are also revised, and related test casts and suppression comments are removed.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Refactor

Suggested reviewers: ndhoule

Merge Risk: ⚪ Minimal · up to 74f1e

The deploy typing changes appear ready to merge after normal checks; no concrete deployment regression remains identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title clearly and concisely describes the main change: replacing weak types in the deploy command and related utilities.
Description check	✅ Passed	The description directly explains the typing refactor, removed weak-type patterns, remaining suppressions, and intended unchanged runtime behavior.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{Comment @coderabbitai help to get the list of available commands.}

github-actions · 2026-10-08T18:09:38Z

📊 Benchmark results

Comparing with 7c3b5c2

Dependency count: 1,019 (no change)
Package size: 380 MB (no change)
Number of ts-expect-error directives: 280 ⬇️ 13.93% decrease vs. 7c3b5c2

pkg-pr-new · 2026-10-08T18:10:00Z

Open in StackBlitz

npm i https://pkg.pr.new/netlify-cli@8599

commit: 7ef3169

serhalp · 2026-10-08T18:37:23Z

      case 'ready': {
-        deploy = siteDeploy
-        return true
+        return pWaitFor.resolveWith(siteDeploy)


Technically this is an exception to the "no changes to runtime code" rule for this PR, but this is really the same behaviour and it unlocks typing this properly.

Replace the `$TSFixMe`/`any` parameters and `@ts-expect-error` markers in the deploy command and `src/utils/deploy/` with real types: Remaining gaps in upstream typings are marked with specific FIXME casts or suppressions. Runtime behaviour is unchanged.

chatgpt-codex-connector · 2026-10-08T19:17:48Z

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

#### Summary Batch 1 of 3 of follow-ups to #8599. Out of an abundance of caution, that PR was kept purely focused on type changes. - Create deploys through a single helper, instead of duplicating across `--build` and `--no-build` - Behaviour change (technically): with `--build`, a deploy response without an `id` no longer falls back to an empty-string deploy ID; the deploy ID is passed through as returned by the API, matching the `--no-build` path. ✅ Verified not possible in backend code. - Use optional chaining where we now can. - Behaviour change (technically): a non-object `published_deploy` (for example a function) with a truthy `locked` property now counts as locked. ✅ Verified not possible in backend code. - Remove optional chaining now revealed to be unnecessary. - Behaviour change (technically) if the types are wrong. ✅ Verified not possible in build and backend code.

serhalp force-pushed the serhalp/build/fix-deploy-types branch from 84e611d to fa00059 Compare October 8, 2026 18:34

serhalp commented Oct 8, 2026

View reviewed changes

serhalp force-pushed the serhalp/build/fix-deploy-types branch from fa00059 to 74f1ee5 Compare October 8, 2026 18:39

serhalp marked this pull request as ready for review October 8, 2026 19:17

serhalp requested a review from a team as a code owner October 8, 2026 19:17

Merge branch 'main' into serhalp/build/fix-deploy-types

7ef3169

akardet self-requested a review October 8, 2026 22:52

akardet approved these changes Oct 8, 2026

View reviewed changes

serhalp merged commit 31ed36f into main Oct 9, 2026
37 checks passed

serhalp deleted the serhalp/build/fix-deploy-types branch October 9, 2026 12:36

serhalp mentioned this pull request Oct 9, 2026

refactor(deploy): consolidate deploy creation logic #8605

Merged

Navigation Menu

Repository navigation

refactor: fix types in deploy command and its utils - #8599

refactor: fix types in deploy command and its utils#8599
serhalp merged 2 commits into
mainfrom
serhalp/build/fix-deploy-types

serhalp commented Oct 8, 2026 •

edited

Loading

Uh oh!

coderabbitai Bot commented Oct 8, 2026 •

edited

Loading

Review skipped

Summary by CodeRabbit

Walkthrough

Uh oh!

github-actions Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Oct 8, 2026 •

edited

Loading

Uh oh!

serhalp Oct 8, 2026

Uh oh!

chatgpt-codex-connector Bot commented Oct 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

serhalp commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

coderabbitai Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Summary by CodeRabbit

Walkthrough

Uh oh!

github-actions Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Benchmark results

Uh oh!

pkg-pr-new Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

serhalp Oct 8, 2026

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Oct 8, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

serhalp commented Oct 8, 2026 •

edited

Loading

coderabbitai Bot commented Oct 8, 2026 •

edited

Loading

github-actions Bot commented Oct 8, 2026 •

edited

Loading

pkg-pr-new Bot commented Oct 8, 2026 •

edited

Loading