Repository navigation
Finish the DCstat legacy-route catalogue migration - #3126
Conversation
✅ Deploy Preview for netdata-docusaurus ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk | ⚪ Minimal · up to
|
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 … | Write docstrings for the functions missing them to satisfy the coverage threshold. |
✅ Passed checks (4 passed)
-
Check name Status Explanation Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description Check Check skipped - CodeRabbit’s high-level summary is enabled. Title check The title clearly and concisely describes the main change: completing the DCstat legacy-route catalogue migration.
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)
- Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
-
📝 Generate docstrings 💡
-
- Commit to this branch
- Create a new PR
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Architecture diagram
sequenceDiagram
participant IG as Ingest Pipeline
participant Cat as Catalogue Service
participant Gate as Redirect Gate
participant Test as Test Suite
participant Source as Go Collector Source
Note over IG,Source: DCstat Catalogue Route Migration (Current State)
IG->>IG: Run catalogue ingestion workflow
IG->>Cat: Query DCstat catalogue entries
Cat->>Cat: Resolve canonical + legacy routes
alt Canonical route (ebpf-dcstat)
Cat->>Source: Map to Go collector integration
Source-->>Cat: ebpf_dcstat.md (Go source)
else Legacy slug (ebpf-dcstat-ebpf-plugin)
Cat->>Source: Map to Go collector integration
Source-->>Cat: ebpf_dcstat.md (Go source)
end
Cat->>Gate: Submit route set for validation
Gate->>Gate: Check fail-closed gate conditions
Gate->>Test: Run redirect validation
Test->>Test: Verify complete route set (5 routes)
Test-->>Gate: Validation results
alt All routes resolved or retained
Gate-->>Cat: Pass - routes valid
Cat->>Cat: Generate documentation + redirects
else Missing route(s)
Gate-->>Cat: Fail - gate stays closed
Cat->>Cat: Retain C source fallback
end
Note over IG,Source: Supported Routes:
Note over IG,Source: 1. /docs/data-collection/ebpf/ebpf-dcstat
Note over IG,Source: 2. /docs/collecting-metrics/ebpf/ebpf-dcstat
Note over IG,Source: 3. /docs/collecting-metrics/operating-systems/ebpf-dcstat
Note over IG,Source: 4. /docs/collecting-metrics/collectors/operating-systems/ebpf-dcstat
Note over IG,Source: 5. .../ebpf-dcstat-ebpf-plugin (legacy slug)
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
DCstat moved from the C collector to the Go collector, but the canonical catalogue entry still names the obsolete producer. A second published C slug also needs a retained destination before that producer is removed.
Map all five DCstat catalogue routes to the Go source, including the canonical route and the suffixed legacy slug. Keep the fail-closed catalogue gate and reviewed-retirement policy unchanged. The existing migration test now names the complete route set.
Validation: 30 catalogue tests and 13 cleanup tests passed. Normal Agent generation followed by full Learn ingestion passed; the result has one DCstat page and one card per collector grid. The exact Node 22.23.2 production build passed the title, heading, redirect, rendered-link, indexability, Cloudflare RUM and static-site gates. A source-only compatibility check also passed against the currently published C and Go mappings.
Merge this catalogue change before removing the Agent preservation and CI-only deletion workaround. Generated documentation and redirects remain owned by the normal ingestion workflow and are not included in this source change.
Summary by cubic
Completes the DCstat legacy-route catalogue migration so all five DCstat documentation routes resolve against the Go collector source instead of the obsolete C producer.
The canonical
ebpf-dcstatroute now maps to the Go integration file, and the suffixed-ebpf-pluginlegacy slug is retained against the same source. The migration test now asserts the complete route set instead of counting three routes.Written for commit 4566b28. Summary will update on new commits.
Summary by CodeRabbit