Repository navigation
fix(config): retention editor repaint and refusing unsupported key spellings - #2417
Merged
Aaronontheweb merged 5 commits intoOct 10, 2026
Merged
Conversation
Aaronontheweb
enabled auto-merge (squash)
October 10, 2026 00:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR fixes the retention defects from #2412.
configVersionassignment, which could add a duplicate key.Change
ConfigEditorSession.Save()after the version assignment and before the file write.config-retentionnative tape to thelightprofile, with JSON and CLI assertions.Validation
pwsh.lightsmoke: 29 tapes and 10 scenarios passed.Local tests and the final smoke profile use runtime source at
2b3bffaef. The later commit changes onlyTOOLING.md.