Repository navigation
Add NativeLdapRootDse method for direct LDAP queries - #75
Open
netanelcyber wants to merge 1 commit into
Open
netanelcyber wants to merge 1 commit into
netanelcyber wants to merge 1 commit into
Conversation
Adds a C# method that queries LDAP RootDSE attributes (defaultNamingContext, forestFunctionality, dnsHostName, etc.) directly via System.DirectoryServices.Protocols, returning results as a JObject. Includes anonymous bind with 10s timeout and proper error handling for LdapException. Also adds the required assembly reference and namespace imports for System.DirectoryServices.Protocols and System.Net. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01W6vJrahr1eQimvjAuoAbpJ
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by NETANEL · project thread
Summary
Before: The LDAP scan workflow had an incomplete line (
var s=new) that would not compile, and there was no native C# method to query LDAP RootDSE attributes directly.After: A complete
NativeLdapRootDse(string ip)method queries RootDSE viaSystem.DirectoryServices.Protocolswith anonymous bind and returns aJObjectcontaining all standard AD attributes (defaultNamingContext, forestFunctionality, dnsHostName, supportedLDAPVersion, etc.).The fixed calling pattern:
How
System.DirectoryServices.Protocolsassembly reference and namespace importSystem.Netnamespace import (for credentials support)NativeLdapRootDseas a static method returningJObjectwith:JArray, single-valued as stringsLdapException(with error code) and general exceptions🤖 Generated with Claude Code
https://claude.ai/code/session_01W6vJrahr1eQimvjAuoAbpJ
Generated by Claude Code