Repository navigation
fix(ci): align release contexts with CircleCI setup - #51
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (4)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughCircleCI release publishing now uses separate GitHub and crates.io credential contexts. GitHub releases remain enabled for tagged releases. Crate publication runs in a separate workflow only when ChangesRelease publishing
Priority: ➖ Normal Estimated code review effort: 3 (Moderate) | ~20 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant CircleCI
participant GitHub
participant crates_io
CircleCI->>GitHub: Upload tagged release assets
CircleCI->>CircleCI: Run verify-crate
CircleCI->>crates_io: Publish when publish_crate=true
Merge Risk: ⚪ Minimal · up to The release configuration and documentation consistently describe separate credential contexts and opt-in crate publishing. No concrete merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use the existing gh-release-publisher context and map its gh_token to GH_TOKEN. Keep crates.io publication explicit and opt-in via a separate crate-release workflow requiring a dedicated cargo-release-publisher context. The v0.3.28 tag run built all five targets and passed verify-release, but publish-release never started because the config referenced nonexistent linear-cli-release. The existing tag/release is intentionally not rewritten. Validation: circleci config validate, circleci config process, git diff --check.
Summary by CodeRabbit
New Features
publish_crate=true.Documentation