Repository navigation
feat: refactor monaco initialization - #1012
Merged
Kevin101Zhang merged 5 commits intoAug 13, 2024
Merged
Conversation
Kevin101Zhang
changed the title
Kevin101Zhang
changed the title
Kevin101Zhang
marked this pull request as ready for review
August 12, 2024 21:39
Contributor
Author
|
File has a strong amount of refactoring. Ill keep the transition to TS in a separate PR. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
all removed files:
refactored ResizableLayout to house the functionality in a reusable dp.
Results are some absurdly fast transitions between tabs.
New Resizable Editor File
Encompasses logic from MonacoEditorComponent,DiffEditorComponent, ResizableLayout, ResizeableLayoutEditor
Upon refactoring resizable (resize.js), and block_details.js were removed as there are no real functionality used around them.