Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Follow up on the review in #3 by storing
sample_sigmasin the QwenImage21 pipeline config (model_index.json) instead of extendingFlowMatchEulerDiscreteScheduler. The scheduler implementation is unchanged.The pipeline passes the selected grid through the scheduler's existing
sigmasargument. For a fixed distilled grid, the checkpoint scheduler config disables dynamic shifting, terminal stretching and sigma conversions, withshift=1.0. The docs include the checkpoint configuration and save/load workflow.Explicit call-time
sigmasoverride the saved pipeline grid. Otherwise the configured grid determines the step count;num_inference_stepsis used only when neither grid is supplied. Loading withfrom_pretrained(..., sample_sigmas=...)can also override the saved default. Explicit grids still go through the scheduler's configured processing.Validation
make styleandmake fix-copiescompleted. The final three changed files match the snapshot used in the real-checkpoint test.This verifies parity for that fixed grid and input. Quality with other grids or four-step sampling has not been evaluated; passing
num_inference_steps=4alone still uses the configured eight-point grid.Self-review
READY. No blocking issues or unused added code found. The new config is exercised through construction, serialization, loading and inference; regression tests call the real scheduler and pipeline. Parameter precedence and scheduler preprocessing are documented. No unresolved review findings; the validation scope is stated above.