Fix #484, reject invalid move-target buffers - #519
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #484.
Reject null or zero-capacity destination buffers before formatting a move target. Document the return contract and extend the existing regression test for untouched zero-length buffers, null pointers, one-byte capacity, exact fits, and existing truncation behavior.
Validation
Debian 12 arm64, GCC 12.2, native cFE/OSAL, EDS disabled:
git diff --checkpassed.The broader CFDP sanitizer run stopped in unchanged
CF_CFDP_CopyStringFromLVon a null source pointer. That separate issue is outside this patch; the sanitizer result above is limited to the move-target regression. Full mission/COSMOS, EDS-enabled and hardware testing were not run.Valid-buffer behavior and public signatures are unchanged.
Contributor: Sylvester Kaczmarek, Personal. No third-party code added. Contributor License Agreement submission status is unverified.