Repository navigation
Conversation
Carries pingdotgg#17850 annotation-css-virtual-module (two commits squashed): the preview annotation stylesheet is compiled by a bundler virtual module with watch rebuilds instead of a checked-in generated file, so desktop builds no longer rewrite tracked sources. Drop this layer at the refresh after pingdotgg#17850 annotation-css-virtual-module merges upstream. Co-authored-by: Mike Olson <1510193+mwolson@users.noreply.github.com>
mwolson
added this pull request to stack #84
October 10, 2026 16:45
mwolson
removed this pull request from stack #84
October 15, 2026 01:56
Owner
Author
|
Dropped at the 2026-10-14 refresh onto upstream 40a7908: merged upstream pingdotgg#17838 annotation-style-sync keeps the generated annotation CSS current at this pin, so this carry of pingdotgg#17850 annotation-css-virtual-module is no longer needed. Re-carry it if a Nightly build leaves AnnotationStyles.generated.ts dirty. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Carries pingdotgg#17850 annotation-css-virtual-module. The preview annotation stylesheet is compiled by a bundler virtual module (
virtual:preview-annotation-css) in the picker preload build, with watch rebuilds, instead of a script that wroteAnnotationStyles.generated.tsinto the source tree. The legacy generated file and script are removed, and the stylesheet the app embeds is unchanged.Why
The checked-in generated file had drifted from its generator, so every desktop build rewrote it and left the Nightly tree dirty, which blocked the next build. This replaces the earlier personal layer #79 annotation-styles-regenerated. Drop this layer at the refresh after pingdotgg#17850 merges upstream.
Checklist