Repository navigation
Conversation
mwolson
added this pull request to stack #77
October 10, 2026 02:41
mwolson
removed this pull request from stack #77
October 10, 2026 15:52
mwolson
added this pull request to stack #81
October 10, 2026 15:53
mwolson
removed this pull request from stack #81
October 10, 2026 16:45
mwolson
added this pull request to stack #84
October 10, 2026 16:45
mwolson
removed this pull request from stack #84
October 15, 2026 01:56
mwolson
force-pushed
the
contrib/minimap-text-selection
branch
from
October 15, 2026 01:56
c1826ab to
859c29e
Compare
mwolson
added this pull request to stack #85
October 15, 2026 01:56
mwolson
removed this pull request from stack #85
October 15, 2026 07:04
mwolson
added this pull request to stack #87
October 15, 2026 07:04
Carries pingdotgg#16748 text-selection-minimap by robertnisipeanu (three commits squashed). A held drag that starts outside the turn minimap is a text selection: when it reaches the strip, the strip and its turn buttons stop taking pointer events until release, so no preview opens and the selection follows the text underneath. Drop this layer at the refresh after pingdotgg#16748 text-selection-minimap merges upstream.
mwolson
force-pushed
the
contrib/minimap-text-selection
branch
from
October 15, 2026 23:03
859c29e to
f4b2cf0
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
Carries pingdotgg#16748 text-selection-minimap by @robertnisipeanu (three commits squashed), plus a regression test added here. Dragging a text selection left onto the turn minimap no longer opens the minimap preview or jumps the selection across the rest of the conversation: a held drag that started outside the strip passes through the strip and its turn buttons until the mouse is released, so the selection follows the text underneath. A press that starts on the strip still scrubs, and hover, click-to-jump and keyboard navigation are unchanged.
Why
The preview card sits after the message list in the DOM, so opening it mid-drag extended the selection over everything after the drag start, and the strip's hit area blocked the first letters of lines under it. Drop this layer at the refresh after pingdotgg#16748 merges upstream.
UI Changes
Before and after recordings are on pingdotgg#16748.
Checklist