Repository navigation
core: tidy the landlock crate conversion - #326
Merged
Merged
Conversation
The read mask was spelled three ways, one of them converting the host ABI through i32 for a set that does not depend on the ABI at all. Name it once as READ_ACCESS. Also drop the fs_write_mask alias of handled_access_fs and two casts that converted u32 to u32, left over from the switch to the landlock crate. Signed-off-by: Cong Wang <cwang@multikernel.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #305, addressing review nits. No behavior change.
READ_ACCESS(Execute, ReadFile, ReadDir). It was built three ways, one of them converting the host ABI throughi32for a set that is the same on every ABI.fs_write_maskalias and usehandled_access_fsdirectly.u32tou32.🤖 Generated with Claude Code