Repository navigation
Conversation
These are not used in CIDs regularly, so size is not a primary concern. As such, adding to a high byte range space.
Contributor
|
So the idea is that these aren't used for codecs, but are magic numbers that may be used... somewhere else, in specific places where we're expecting to talk about ADLs, such as in a field of integer type in a selector extension we're about to propose? |
Contributor
Author
|
in general i would not expect them to be directly embedded as CIDs, but they are sufficiently cid-adjacent that they should not conflict with other defined multi-codecs, and I believe warrant their own namespace in the multicodec registry in which to be defined and delineated. |
Stebalien
reviewed
Mar 2, 2022
Stebalien
left a comment
Stebalien
left a comment
Member
There was a problem hiding this comment.
No reason not to merge these as draft codes.
Stebalien
approved these changes
Mar 2, 2022
Member
|
Nvm. Apparently we're not using codecs. |
Contributor
Author
|
this got deprecated in favor strings |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are not used in CIDs regularly, so size is not a primary concern. As such, adding to a high byte range space.