Skip to content

Adding back erased tests and making sure they work - #20

Merged
pose merged 3 commits into
masterfrom
chores/restore-tests-and-ci-ok
Sep 12, 2013
Merged

pose merged 3 commits into
masterfrom
chores/restore-tests-and-ci-ok

Conversation

@pose

@pose pose commented Sep 11, 2013

Copy link
Copy Markdown
Contributor

Tests are run by doing

grunt test

Changelog:

  • Adding back some valid tests that were removed during the cleanup
  • Making sure that those tests run in CI correctly. Currently, Bamboo is not supporting Bower 😠 so I'm removing tests dependencies from it. You can see how the the build is passing.
  • PhantomJS is not supporting natively function () {}.bind(). (that's why a workaround for Function.prototype.bind is added). This issue has been created for QA to follow up.

@pose

pose commented Sep 11, 2013

Copy link
Copy Markdown
Contributor Author

BTW, I'm migrating those tests to use should soon ✌️

@ghost ghost assigned shamus Sep 11, 2013
@tokafish

Copy link
Copy Markdown
Contributor

@pose question about the ramlReader service:

Is it used by both the editor and console? Which app owns it?

@pose

pose commented Sep 11, 2013

Copy link
Copy Markdown
Contributor Author

It's heavy used by the console. It's a service for massaging the data and converting it in a more easy to display format. In editor there are two methods of the service used:

  • ramlReader.read(result)
  • ramlReader.processBaseUri(definition);

@tokafish

Copy link
Copy Markdown
Contributor

So this service is duplicated in both apps? Can we safely alter the one in console without breaking the editor?

@pose

pose commented Sep 11, 2013

Copy link
Copy Markdown
Contributor Author

@wless1 @jeremysmears Let me know if based on today's meeting this works for you or shall we wait to have Mocha running before merging this. Thanks

pose added a commit that referenced this pull request Sep 12, 2013
…tests-and-ci-ok

Adding back erased tests and making sure they work
@pose
pose merged commit 7ccbb13 into master Sep 12, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants