Repository navigation
Adding back erased tests and making sure they work - #20
Merged
Merged
Conversation
Contributor
Author
|
BTW, I'm migrating those tests to use |
Contributor
|
@pose question about the ramlReader service: Is it used by both the editor and console? Which app owns it? |
Contributor
Author
|
It's heavy used by the console. It's a service for massaging the data and converting it in a more easy to display format. In editor there are two methods of the service used:
|
Contributor
|
So this service is duplicated in both apps? Can we safely alter the one in console without breaking the editor? |
Contributor
Author
|
@wless1 @jeremysmears Let me know if based on today's meeting this works for you or shall we wait to have Mocha running before merging this. Thanks |
pose
added a commit
that referenced
this pull request
Sep 12, 2013
…tests-and-ci-ok Adding back erased tests and making sure they work
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests are run by doing
Changelog:
function () {}.bind(). (that's why a workaround for Function.prototype.bind is added). This issue has been created for QA to follow up.