Fill empty Quick fix notes cells; correct digit ink-centering in diagram - #82
Merged
Merged
Conversation
AFFECTED-SYSTEMS.md: the six rows with an empty third column now carry an actual fix path instead of blank space. Where a vendor advisory was read directly (Konica Minolta/DEVELOP, Xerox) the note says what to check and what to do when firmware won't help, linking the matching PRINTERS.md section. Verified both anchor targets (#xerox, #konica-minolta) resolve to real id attributes in the built HTML, and re-checked all 20 URLs in the file return 200. setup-comparison.svg: the earlier x=cx fix wasn't enough. text-anchor ="middle" centers the glyph's *advance box*, not its visible ink, and getBBox() on SVG text reports that same advance box - which is why the first measurement misleadingly showed a 0px offset. Measured true ink extents via canvas TextMetrics (actualBoundingBoxLeft/Right) in the real font instead: digit "1" sits 0.66px left of center (5px ink in a 6.33px advance, asymmetric bearings), digits 2-5 sit 0.16px left. Applied those exact values as dx, keeping x equal to cx so the geometry stays self-documenting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AFFECTED-SYSTEMS.md — the six rows that had an empty "Quick fix notes" cell now carry a real fix path. For the two vendors whose advisories were read directly (Konica Minolta/DEVELOP, Xerox) the note states what to check and what to do when firmware won't help, linking the matching PRINTERS.md brand section.
Link integrity verified per the request: all 20 URLs in the file return 200, and both new anchor targets (
#xerox,#konica-minolta) resolve to realidattributes in the builtPRINTERS.html.setup-comparison.svg — the previous
x=cxfix was insufficient.text-anchor="middle"centers a glyph's advance box, not its visible ink — andgetBBox()on SVG text returns that same advance box, which is why my first measurement misleadingly reported a 0px offset. Re-measured true ink extents with canvasTextMetrics(actualBoundingBoxLeft/Right) in the real font:Applied those exact values as
dx, leavingxequal tocxso the geometry stays self-documenting.Test plan
<td></td>in the table.dxcorrections present in the deployed SVG.🤖 Generated with Claude Code