Skip to content
This repository was archived by the owner on Feb 13, 2024. It is now read-only.

Add ability to pin tasks as notifications - #1170

Merged
mpcjanssen merged 1 commit into
mpcjanssen:masterfrom
camgraff:feat/pin_notification
May 3, 2022
Merged

Add ability to pin tasks as notifications#1170
mpcjanssen merged 1 commit into
mpcjanssen:masterfrom
camgraff:feat/pin_notification

Conversation

@camgraff

@camgraff camgraff commented May 3, 2022

Copy link
Copy Markdown
Contributor

Partially addresses #964.

Adds an additional button to the task bar that allows pinning tasks as notifications. A task can be marked complete from the notification. When a task is edited/completed inside the app the notification is also updated accordingly.

simpletask-notification

@mpcjanssen
mpcjanssen merged commit 3700a4c into mpcjanssen:master May 3, 2022
@mpcjanssen

Copy link
Copy Markdown
Owner

Thanks very nice.

@smichel17

smichel17 commented May 5, 2022

Copy link
Copy Markdown
Collaborator

Agreed it's very nice, but one nitpick: this will make the bottom bar overflow on small-screen devices. See also #1154, where I mentioned the same concern.

Conceptually, I think it would be best to keep the bottom bar for actions that directly change the task text. There's some options for what to do for everything else.

  • The least effort is to just move them to the top bar, in an overflow menu if needed.
  • The best solution, imo, is to change the FAB so that it expands into a menu of some sort.
  • A compromise between effort and functionality is to make a row of small-size FABs floating above the bottom bar.

@camgraff Would you be up for doing one of those as a follow up? If so, let me know which option you're interested in (or propose an idea/opinion I didn't list) and I can share some more detailed thoughts.

@camgraff

Copy link
Copy Markdown
Contributor Author

@smichel17 yeah these seem like good ideas.

Conceptually, I think it would be best to keep the bottom bar for actions that directly change the task text.

Agreed. I saw in #1154 you mentioned moving the "edit" button. Would you put that in the FAB menu as well?

The least effort is to just move them to the top bar, in an overflow menu if needed.

I like that this keeps the action one tap away where as a FAB menu would involve an extra tap.

A compromise between effort and functionality is to make a row of small-size FABs floating above the bottom bar.

Not thrilled about this one, multiple FABs feels clunky and they'd start to block text at the bottom of the list.

@smichel17

Copy link
Copy Markdown
Collaborator

Sorry for taking so long to get back to this, I got busy and it slipped off my rader. I opened #1182 to track this (and summarized all my current thoughts on the issue) so we're not just discussing in a merged PR.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants