Skip to content

JS should not add 'aria-expanded=false' to .mzp-c-navigation-items #847

Description

@stephaniehobson

aria-expanded=false is being added to .mzp-c-navigation-items.

This role should be declared on a controlling element like a button or link and must be used with aria-controls. Also, on desktop this content is expanded by default so it should not be false.

Wild speculation about the cause of this:

I think it should be on c-navigation-menu-button instead. Since the button is hidden I don't know if it would be confusing to a screen reader to have it declared false or not. We can fix it to be true on desktop or do research to see if that's necessary and document that it is not.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

A11y ♿️Accessibility issuesBug 🪲Something isn't workingDev ready ⚙️Indicates the story/card/tasks are ready to be codedP2Second level priority - Should haveSize: XSEst. half-day of work

Type

No type

Fields

Priority

None yet

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions