Repository navigation
Improve the find bar integration tests - #22069
Open
timvandermeij wants to merge 3 commits into
Open
timvandermeij wants to merge 3 commits into
timvandermeij wants to merge 3 commits into
Conversation
timvandermeij
force-pushed
the
find-bar-coverage
branch
from
October 4, 2026 16:36
1c65d5b to
71c64e8
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22069 +/- ##
==========================================
+ Coverage 90.23% 90.24% +0.01%
==========================================
Files 277 277
Lines 67807 67807
==========================================
+ Hits 61186 61195 +9
+ Misses 6621 6612 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
calixteman
reviewed
Oct 4, 2026
calixteman
reviewed
Oct 4, 2026
calixteman
reviewed
Oct 4, 2026
calixteman
reviewed
Oct 4, 2026
calixteman
reviewed
Oct 4, 2026
timvandermeij
force-pushed
the
find-bar-coverage
branch
2 times, most recently
from
October 6, 2026 19:10
3cf7746 to
d9b38d7
Compare
…tion tests This refactoring makes the existing tests more compact/expressive, and makes it easier to add more find bar tests in a next commit without having to duplicate this logic more often.
This makes the test names more consistent to improve clarity on what the tests aim to check, and avoids using duplicate test names to make discovery of e.g. failed tests easier in the logs.
This commit brings code coverage for the `web/pdf_find_bar.js` file to 100% by covering all missing cases, which include: - searching with no results; - searching with multiple results; - highlighting all search results using keyboard navigation; - closing the find bar via the toolbar button and the Escape key.
timvandermeij
force-pushed
the
find-bar-coverage
branch
from
October 8, 2026 21:43
d9b38d7 to
4212096
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit messages contain more details about the individual changes.