Repository navigation
Keep find-result scrolling inside the PDF viewer - #22043
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22043 +/- ##
=======================================
Coverage 90.35% 90.36%
=======================================
Files 269 269
Lines 67205 67212 +7
=======================================
+ Hits 60723 60736 +13
+ Misses 6482 6476 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22009.
Keep search-result scrolling inside the viewer container so an embedded viewer does not move its parent page. Use transformed client rectangles to preserve the rotated-text behavior and existing scroll margin, with the native fallback retained for controllers without a viewer.
Added an iframe regression that navigates three matches and checks both match visibility and the parent scroll position. It fails before the fix (parent scroll moves from 600 to 832).
Validation:
pdf_find_controllerunit specs pass.