Repository navigation
Add helper functions for encoding and writing strings in src/core/obj_bin_transform_core.js - #22016
Merged
Snuffleupagus merged 3 commits intoSep 29, 2026
Merged
Conversation
Contributor
Reference testsResults for 8905373 (run, references from mozilla/pdf.js.refs@e990d937ae).
The report is kept for 30 days and replaced by the next run. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22016 +/- ##
==========================================
+ Coverage 90.36% 90.37% +0.01%
==========================================
Files 269 269
Lines 67233 67201 -32
==========================================
- Hits 60753 60733 -20
+ Misses 6480 6468 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Sep 24, 2026
Snuffleupagus
force-pushed
the
compile-writeStrings
branch
from
September 24, 2026 12:25
c57a674 to
e755eb1
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Sep 24, 2026
Snuffleupagus
marked this pull request as draft
September 24, 2026 13:07
Snuffleupagus
marked this pull request as ready for review
September 24, 2026 13:08
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Sep 24, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Sep 24, 2026
Snuffleupagus
force-pushed
the
compile-writeStrings
branch
from
September 24, 2026 20:17
23c5ddb to
ea9f1ef
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Sep 24, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Sep 24, 2026
…j_bin_transform_core.js` Currently `compileCssFontInfo`, `compileSystemFontInfo`, and `compileFontInfo` duplicate the same exact code for encoding and writing strings, which can be avoided with the introduction of two new helpers. *Note:* This reduces the size of the `gulp mozcentral` bundle by `450` bytes, which isn't a lot but still cannot hurt.
…ings in `compileSystemFontInfo` *Note:* This reduces the size of the `gulp mozcentral` bundle by `281` bytes, which isn't a lot but still cannot hurt.
After the previous patches the total length of the encoded strings are consistently available *before* writing them, hence we can directly set the length and remove the temporary (i.e. zero) placeholder entry.
Snuffleupagus
force-pushed
the
compile-writeStrings
branch
from
September 29, 2026 07:29
ea9f1ef to
8905373
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Sep 29, 2026
Snuffleupagus
requested review from
calixteman
and removed request for
calixteman
September 29, 2026 07:43
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently
compileCssFontInfo,compileSystemFontInfo, andcompileFontInfoduplicate the same exact code for encoding and writing strings, which can be avoided with the introduction of two new helpers.Note: This reduces the size of the
gulp mozcentralbundle by450bytes, which isn't a lot but still cannot hurt.