Repository navigation
Remove unneeded async functions when creating StructTreeRoot-data during saving (PR 19026) - #22015
Merged
Snuffleupagus merged 1 commit intoSep 29, 2026
Conversation
…uring saving (PR 19026) These functions no longer need to be `async` after PR 19026, since no value is being returned now, and instead we can directly return the `StructTreeRoot.createStructureTree` respectively `StructTreeRoot.prototype.updateStructureTree` call since both methods (implicitly) return undefined.
Contributor
Reference testsResults for aea270c (run, references from mozilla/pdf.js.refs@27850b238a).
The report is kept for 30 days and replaced by the next run. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22015 +/- ##
=======================================
Coverage 90.37% 90.37%
=======================================
Files 269 269
Lines 67272 67272
=======================================
+ Hits 60794 60797 +3
+ Misses 6478 6475 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Sep 24, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions no longer need to be
asyncafter PR #19026, since no value is being returned now, and instead we can directly return theStructTreeRoot.createStructureTreerespectivelyStructTreeRoot.prototype.updateStructureTreecall since both methods (implicitly) return undefined.