Skip to content

Bound tiling pattern folding work for tiny steps - #22012

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:tiling-pattern-tiny-steps-dos
Oct 2, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:tiling-pattern-tiny-steps-dos

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Fold rows, then columns, and cap offsets by the rendered tile dimensions. For the 10x10 fixture with 0.001 steps at scale 1, this reduces folding from 100,020,001 drawImage calls to 22. Descending offsets draw the origin tile last.

Add rendering tests for tiny steps, far-corner content, and overlap order.

@codecov-commenter

codecov-commenter commented Sep 23, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.35%. Comparing base (18e8a26) to head (cf2db3a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22012      +/-   ##
==========================================
- Coverage   90.35%   90.35%   -0.01%     
==========================================
  Files         269      269              
  Lines       67205    67214       +9     
==========================================
+ Hits        60723    60730       +7     
- Misses       6482     6484       +2     
Flag Coverage Δ
browsertest 66.17% <100.00%> (+<0.01%) ⬆️
fonttest 8.98% <ø> (ø)
integrationtest 69.38% <0.00%> (-0.01%) ⬇️
unittest 59.53% <100.00%> (+0.03%) ⬆️
unittestcli 58.05% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Sep 23, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 3f9c2e6 (run, references from mozilla/pdf.js.refs@27850b238a).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1380 11m 10s 0 1 0 0 view differences
Windows ⚠️ 1380 16m 22s 0 2 0 0 view differences

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Sep 23, 2026
Fold rows, then columns, and cap offsets by the rendered tile dimensions.
For the 10x10 fixture with 0.001 steps at scale 1, this reduces folding
from 100,020,001 drawImage calls to 22. Descending offsets draw the origin
tile last.

Add rendering tests for tiny steps, far-corner content, and overlap order.
@timvandermeij
timvandermeij merged commit c7e2fe4 into mozilla:master Oct 2, 2026
23 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants